| From fb239c1209bb0f0b4830cc72507cc2f2d63fadbd Mon Sep 17 00:00:00 2001 |
| From: Matthias Kaehlcke <mka@chromium.org> |
| Date: Thu, 8 Feb 2018 16:57:12 -0800 |
| Subject: rtlwifi: rtl8192cu: Remove variable self-assignment in rf.c |
| |
| From: Matthias Kaehlcke <mka@chromium.org> |
| |
| commit fb239c1209bb0f0b4830cc72507cc2f2d63fadbd upstream. |
| |
| In _rtl92c_get_txpower_writeval_by_regulatory() the variable writeVal |
| is assigned to itself in an if ... else statement, apparently only to |
| document that the branch condition is handled and that a previously read |
| value should be returned unmodified. The self-assignment causes clang to |
| raise the following warning: |
| |
| drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c:304:13: |
| error: explicitly assigning value of variable of type 'u32' |
| (aka 'unsigned int') to itself [-Werror,-Wself-assign] |
| writeVal = writeVal; |
| |
| Delete the branch with the self-assignment. |
| |
| Signed-off-by: Matthias Kaehlcke <mka@chromium.org> |
| Acked-by: Larry Finger <Larry.Finger@lwfinger.net> |
| Reviewed-by: Guenter Roeck <groeck@chromium.org> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c | 3 --- |
| 1 file changed, 3 deletions(-) |
| |
| --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c |
| +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.c |
| @@ -304,9 +304,6 @@ static void _rtl92c_get_txpower_writeval |
| writeVal = 0x00000000; |
| if (rtlpriv->dm.dynamic_txhighpower_lvl == TXHIGHPWRLEVEL_BT1) |
| writeVal = writeVal - 0x06060606; |
| - else if (rtlpriv->dm.dynamic_txhighpower_lvl == |
| - TXHIGHPWRLEVEL_BT2) |
| - writeVal = writeVal; |
| *(p_outwriteval + rf) = writeVal; |
| } |
| } |