| From ae481cc139658e89eb3ea671dd00b67bd87f01a3 Mon Sep 17 00:00:00 2001 |
| From: Wolfram Sang <wsa+renesas@sang-engineering.com> |
| Date: Tue, 18 Apr 2017 20:38:35 +0200 |
| Subject: i2c: rcar: fix resume by always initializing registers before transfer |
| |
| From: Wolfram Sang <wsa+renesas@sang-engineering.com> |
| |
| commit ae481cc139658e89eb3ea671dd00b67bd87f01a3 upstream. |
| |
| Resume failed because of uninitialized registers. Instead of adding a |
| resume callback, we simply initialize registers before every transfer. |
| This lightweight change is more robust and will keep us safe if we ever |
| need support for power domains or dynamic frequency changes. |
| |
| Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> |
| Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> |
| Signed-off-by: Wolfram Sang <wsa@the-dreams.de> |
| Cc: Ben Hutchings <ben.hutchings@codethink.co.uk> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/i2c/busses/i2c-rcar.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/i2c/busses/i2c-rcar.c |
| +++ b/drivers/i2c/busses/i2c-rcar.c |
| @@ -484,6 +484,8 @@ static int rcar_i2c_master_xfer(struct i |
| |
| pm_runtime_get_sync(dev); |
| |
| + rcar_i2c_init(priv); |
| + |
| ret = rcar_i2c_bus_barrier(priv); |
| if (ret < 0) |
| goto out; |
| @@ -624,7 +626,6 @@ static int rcar_i2c_probe(struct platfor |
| if (ret < 0) |
| goto out_pm_put; |
| |
| - rcar_i2c_init(priv); |
| pm_runtime_put(dev); |
| |
| irq = platform_get_irq(pdev, 0); |
