| From a9081a75df128dcecc82e1974ce071189c64654f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 29 Jan 2019 16:03:24 +0800 |
| Subject: ARM: pxa: ssp: Fix "WARNING: invalid free of devm_ allocated data" |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| [ Upstream commit 9ee8578d953023cc57e7e736ae48502c707c0210 ] |
| |
| Since commit 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") |
| kfree, iounmap, clk_put etc are not needed anymore in remove path. |
| |
| Fixes: 1c459de1e645 ("ARM: pxa: ssp: use devm_ functions") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| [ commit message spelling fix ] |
| Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm/plat-pxa/ssp.c | 6 ------ |
| 1 file changed, 6 deletions(-) |
| |
| diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c |
| index b92673efffffb..97bd43c16cd87 100644 |
| --- a/arch/arm/plat-pxa/ssp.c |
| +++ b/arch/arm/plat-pxa/ssp.c |
| @@ -230,18 +230,12 @@ static int pxa_ssp_probe(struct platform_device *pdev) |
| |
| static int pxa_ssp_remove(struct platform_device *pdev) |
| { |
| - struct resource *res; |
| struct ssp_device *ssp; |
| |
| ssp = platform_get_drvdata(pdev); |
| if (ssp == NULL) |
| return -ENODEV; |
| |
| - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| - release_mem_region(res->start, resource_size(res)); |
| - |
| - clk_put(ssp->clk); |
| - |
| mutex_lock(&ssp_lock); |
| list_del(&ssp->node); |
| mutex_unlock(&ssp_lock); |
| -- |
| 2.20.1 |
| |
