| From 9a8d5ecb75df262b38cd50a66522a7dcc24b877d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 26 Dec 2018 08:36:58 -0500 |
| Subject: clk: armada-370: fix refcount leak in a370_clk_init() |
| |
| From: Yangtao Li <tiny.windzz@gmail.com> |
| |
| [ Upstream commit a3c24050bdf70c958a8d98c2823b66ea761e6a31 ] |
| |
| The of_find_compatible_node() returns a node pointer with refcount |
| incremented, but there is the lack of use of the of_node_put() when |
| done. Add the missing of_node_put() to release the refcount. |
| |
| Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> |
| Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com> |
| Fixes: 07ad6836fa21 ("clk: mvebu: armada-370: maintain clock init order") |
| Signed-off-by: Stephen Boyd <sboyd@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/clk/mvebu/armada-370.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/clk/mvebu/armada-370.c b/drivers/clk/mvebu/armada-370.c |
| index 2c7c1085f8830..8fdfa97900cd8 100644 |
| --- a/drivers/clk/mvebu/armada-370.c |
| +++ b/drivers/clk/mvebu/armada-370.c |
| @@ -177,8 +177,10 @@ static void __init a370_clk_init(struct device_node *np) |
| |
| mvebu_coreclk_setup(np, &a370_coreclks); |
| |
| - if (cgnp) |
| + if (cgnp) { |
| mvebu_clk_gating_setup(cgnp, a370_gating_desc); |
| + of_node_put(cgnp); |
| + } |
| } |
| CLK_OF_DECLARE(a370_clk, "marvell,armada-370-core-clock", a370_clk_init); |
| |
| -- |
| 2.20.1 |
| |