| From e66a0084be9ffedc0061b7e63676db6617138ffb Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 14 Jan 2019 13:49:46 +0300 |
| Subject: drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit f8261c376e7f8cb9024af5a6c54be540c7f9108e ] |
| |
| The etnaviv_gem_get_pages() never returns NULL. It returns error |
| pointers on error. |
| |
| Fixes: a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Lucas Stach <l.stach@pengutronix.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/etnaviv/etnaviv_dump.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c |
| index 2bef501d4a172..5af7c2594a79e 100644 |
| --- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c |
| +++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c |
| @@ -206,7 +206,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu) |
| mutex_lock(&obj->lock); |
| pages = etnaviv_gem_get_pages(obj); |
| mutex_unlock(&obj->lock); |
| - if (pages) { |
| + if (!IS_ERR(pages)) { |
| int j; |
| |
| iter.hdr->data[0] = bomap - bomap_start; |
| -- |
| 2.20.1 |
| |
