| From 7886129c73a22f36a40a77df5a6a18b65c83d119 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 19 Nov 2018 11:32:41 +0800 |
| Subject: exportfs: fix 'passing zero to ERR_PTR()' warning |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| [ Upstream commit 909e22e05353a783c526829427e9a8de122fba9c ] |
| |
| Fix a static code checker warning: |
| fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR' |
| |
| The error path for lookup_one_len_unlocked failure |
| should set err to PTR_ERR. |
| |
| Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| fs/exportfs/expfs.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/fs/exportfs/expfs.c b/fs/exportfs/expfs.c |
| index 3706939e5dd5e..1730122b10e06 100644 |
| --- a/fs/exportfs/expfs.c |
| +++ b/fs/exportfs/expfs.c |
| @@ -146,6 +146,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt, |
| tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf)); |
| if (IS_ERR(tmp)) { |
| dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp)); |
| + err = PTR_ERR(tmp); |
| goto out_err; |
| } |
| if (tmp != dentry) { |
| -- |
| 2.20.1 |
| |
