| From 25611b8cf7065b3bb4d1e17bf3bb48cff0f539e7 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 5 Sep 2019 01:45:54 +0000 |
| Subject: hwmon: (shtc1) fix shtc1 and shtw1 id mask |
| |
| From: Dan Robertson <dan@dlrobertson.com> |
| |
| [ Upstream commit fdc7d8e829ec755c5cfb2f5a8d8c0cdfb664f895 ] |
| |
| Fix an error in the bitmaskfor the shtc1 and shtw1 bitmask used to |
| retrieve the chip ID from the ID register. See section 5.7 of the shtw1 |
| or shtc1 datasheet for details. |
| |
| Fixes: 1a539d372edd9832444e7a3daa710c444c014dc9 ("hwmon: add support for Sensirion SHTC1 sensor") |
| Signed-off-by: Dan Robertson <dan@dlrobertson.com> |
| Link: https://lore.kernel.org/r/20190905014554.21658-3-dan@dlrobertson.com |
| [groeck: Reordered to be first in series and adjusted accordingly] |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/hwmon/shtc1.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/hwmon/shtc1.c b/drivers/hwmon/shtc1.c |
| index decd7df995abf..2a18539591eaf 100644 |
| --- a/drivers/hwmon/shtc1.c |
| +++ b/drivers/hwmon/shtc1.c |
| @@ -38,7 +38,7 @@ static const unsigned char shtc1_cmd_read_id_reg[] = { 0xef, 0xc8 }; |
| |
| /* constants for reading the ID register */ |
| #define SHTC1_ID 0x07 |
| -#define SHTC1_ID_REG_MASK 0x1f |
| +#define SHTC1_ID_REG_MASK 0x3f |
| |
| /* delays for non-blocking i2c commands, both in us */ |
| #define SHTC1_NONBLOCKING_WAIT_TIME_HPM 14400 |
| -- |
| 2.20.1 |
| |
