| From d01ce74f48c05dd64371e6ffe6cd597deece31d3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 15 Aug 2019 12:58:46 +0100 |
| Subject: iio: dac: ad5380: fix incorrect assignment to val |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| [ Upstream commit b1e18768ef1214c0a8048327918a182cabe09f9d ] |
| |
| Currently the pointer val is being incorrectly incremented |
| instead of the value pointed to by val. Fix this by adding |
| in the missing * indirection operator. |
| |
| Addresses-Coverity: ("Unused value") |
| Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> |
| Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/iio/dac/ad5380.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c |
| index 97d2c5111f438..8bf7fc626a9d4 100644 |
| --- a/drivers/iio/dac/ad5380.c |
| +++ b/drivers/iio/dac/ad5380.c |
| @@ -221,7 +221,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev, |
| if (ret) |
| return ret; |
| *val >>= chan->scan_type.shift; |
| - val -= (1 << chan->scan_type.realbits) / 2; |
| + *val -= (1 << chan->scan_type.realbits) / 2; |
| return IIO_VAL_INT; |
| case IIO_CHAN_INFO_SCALE: |
| *val = 2 * st->vref; |
| -- |
| 2.20.1 |
| |
