| From e22fb2c31bbc8646ecddd2aca48809a1f193fa6c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 22 Feb 2019 01:37:02 -0500 |
| Subject: media: cx18: update *pos correctly in cx18_read_pos() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 7afb0df554292dca7568446f619965fb8153085d ] |
| |
| We should be updating *pos. The current code is a no-op. |
| |
| Fixes: 1c1e45d17b66 ("V4L/DVB (7786): cx18: new driver for the Conexant CX23418 MPEG encoder chip") |
| |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/pci/cx18/cx18-fileops.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/pci/cx18/cx18-fileops.c b/drivers/media/pci/cx18/cx18-fileops.c |
| index df837408efd59..0171dc5b8809e 100644 |
| --- a/drivers/media/pci/cx18/cx18-fileops.c |
| +++ b/drivers/media/pci/cx18/cx18-fileops.c |
| @@ -490,7 +490,7 @@ static ssize_t cx18_read_pos(struct cx18_stream *s, char __user *ubuf, |
| |
| CX18_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc); |
| if (rc > 0) |
| - pos += rc; |
| + *pos += rc; |
| return rc; |
| } |
| |
| -- |
| 2.20.1 |
| |
