| From 9765dd147da265681eb8897297a1dbadeafa2dbf Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 22 Feb 2019 01:36:41 -0500 |
| Subject: media: ivtv: update *pos correctly in ivtv_read_pos() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit f8e579f3ca0973daef263f513da5edff520a6c0d ] |
| |
| We had intended to update *pos, but the current code is a no-op. |
| |
| Fixes: 1a0adaf37c30 ("V4L/DVB (5345): ivtv driver for Conexant cx23416/cx23415 MPEG encoder/decoder") |
| |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/pci/ivtv/ivtv-fileops.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/pci/ivtv/ivtv-fileops.c b/drivers/media/pci/ivtv/ivtv-fileops.c |
| index c9bd018e53de6..e2b19c3eaa876 100644 |
| --- a/drivers/media/pci/ivtv/ivtv-fileops.c |
| +++ b/drivers/media/pci/ivtv/ivtv-fileops.c |
| @@ -420,7 +420,7 @@ static ssize_t ivtv_read_pos(struct ivtv_stream *s, char __user *ubuf, size_t co |
| |
| IVTV_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc); |
| if (rc > 0) |
| - pos += rc; |
| + *pos += rc; |
| return rc; |
| } |
| |
| -- |
| 2.20.1 |
| |
