| From 9a19913cdbbd6dbd00e7d54f7a82961864e233cc Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 25 Sep 2019 13:56:04 +0300 |
| Subject: net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 25a584955f020d6ec499c513923fb220f3112d2b ] |
| |
| The "priv->phy_interface" variable is an enum and in this context GCC |
| will treat it as unsigned so the error handling will never be |
| triggered. |
| |
| Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Acked-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c |
| index 95874c10c23b6..e3b41af65d188 100644 |
| --- a/drivers/net/ethernet/broadcom/bcmsysport.c |
| +++ b/drivers/net/ethernet/broadcom/bcmsysport.c |
| @@ -1773,7 +1773,7 @@ static int bcm_sysport_probe(struct platform_device *pdev) |
| |
| priv->phy_interface = of_get_phy_mode(dn); |
| /* Default to GMII interface mode */ |
| - if (priv->phy_interface < 0) |
| + if ((int)priv->phy_interface < 0) |
| priv->phy_interface = PHY_INTERFACE_MODE_GMII; |
| |
| /* In the case of a fixed PHY, the DT node associated |
| -- |
| 2.20.1 |
| |
