| From 9fdf281b3567e9df1a95b9dd08ea1ca42e695644 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 1 May 2019 16:47:05 +0300 |
| Subject: net: ena: fix: Free napi resources when ena_up() fails |
| |
| From: Sameeh Jubran <sameehj@amazon.com> |
| |
| [ Upstream commit b287cdbd1cedfc9606682c6e02b58d00ff3a33ae ] |
| |
| ena_up() calls ena_init_napi() but does not call ena_del_napi() in |
| case of failure. This causes a segmentation fault upon rmmod when |
| netif_napi_del() is called. Fix this bug by calling ena_del_napi() |
| before returning error from ena_up(). |
| |
| Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") |
| Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com> |
| Signed-off-by: Sameeh Jubran <sameehj@amazon.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c |
| index 961f31c8356b7..da21886609e30 100644 |
| --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c |
| +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c |
| @@ -1702,6 +1702,7 @@ err_setup_rx: |
| err_setup_tx: |
| ena_free_io_irq(adapter); |
| err_req_irq: |
| + ena_del_napi(adapter); |
| |
| return rc; |
| } |
| -- |
| 2.20.1 |
| |
