| From 28ff319074745bc1fc01fc20c8185c1a6549d4be Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 25 Sep 2019 13:55:32 +0300 |
| Subject: net: hisilicon: Fix signedness bug in hix5hd2_dev_probe() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 002dfe8085255b7bf1e0758c3d195c5412d35be9 ] |
| |
| The "priv->phy_mode" variable is an enum and in this context GCC will |
| treat it as unsigned to the error handling will never trigger. |
| |
| Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c |
| index e69a6bed31a95..dd24c352b2000 100644 |
| --- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c |
| +++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c |
| @@ -929,7 +929,7 @@ static int hix5hd2_dev_probe(struct platform_device *pdev) |
| goto err_free_mdio; |
| |
| priv->phy_mode = of_get_phy_mode(node); |
| - if (priv->phy_mode < 0) { |
| + if ((int)priv->phy_mode < 0) { |
| netdev_err(ndev, "not find phy-mode\n"); |
| ret = -EINVAL; |
| goto err_mdiobus; |
| -- |
| 2.20.1 |
| |
