| From cbdb3a79e71a2303b75f95bf6ea24429678ab4b6 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 25 Sep 2019 13:58:22 +0300 |
| Subject: net: stmmac: dwmac-meson8b: Fix signedness bug in probe |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit f10210517a2f37feea2edf85eb34c98977265c16 ] |
| |
| The "dwmac->phy_mode" is an enum and in this context GCC treats it as |
| an unsigned int so the error handling is never triggered. |
| |
| Fixes: 566e82516253 ("net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c |
| index f356a44bcb811..6704d3e0392dc 100644 |
| --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c |
| +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c |
| @@ -280,7 +280,7 @@ static int meson8b_dwmac_probe(struct platform_device *pdev) |
| |
| dwmac->pdev = pdev; |
| dwmac->phy_mode = of_get_phy_mode(pdev->dev.of_node); |
| - if (dwmac->phy_mode < 0) { |
| + if ((int)dwmac->phy_mode < 0) { |
| dev_err(&pdev->dev, "missing phy-mode property\n"); |
| ret = -EINVAL; |
| goto err_remove_config_dt; |
| -- |
| 2.20.1 |
| |
