| From 9b764aadd84daa5454b3d0a677d64b11f0e72eec Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 25 Sep 2019 14:01:00 +0300 |
| Subject: of: mdio: Fix a signedness bug in of_phy_get_and_connect() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit d7eb651212fdbafa82d485d8e76095ac3b14c193 ] |
| |
| The "iface" variable is an enum and in this context GCC treats it as |
| an unsigned int so the error handling is never triggered. |
| |
| Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/of/of_mdio.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c |
| index 262281bd68fa3..1e70851b15308 100644 |
| --- a/drivers/of/of_mdio.c |
| +++ b/drivers/of/of_mdio.c |
| @@ -353,7 +353,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev, |
| struct phy_device *phy; |
| |
| iface = of_get_phy_mode(np); |
| - if (iface < 0) |
| + if ((int)iface < 0) |
| return NULL; |
| |
| phy_np = of_parse_phandle(np, "phy-handle", 0); |
| -- |
| 2.20.1 |
| |
