| From ac953703728a3c3849b31a1a8e3cf83c4d8ef828 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 27 Oct 2018 15:49:26 +0100 |
| Subject: pcrypt: use format specifier in kobject_add |
| |
| From: Colin Ian King <colin.king@canonical.com> |
| |
| [ Upstream commit b1e3874c75ab15288f573b3532e507c37e8e7656 ] |
| |
| Passing string 'name' as the format specifier is potentially hazardous |
| because name could (although very unlikely to) have a format specifier |
| embedded in it causing issues when parsing the non-existent arguments |
| to these. Follow best practice by using the "%s" format string for |
| the string 'name'. |
| |
| Cleans up clang warning: |
| crypto/pcrypt.c:397:40: warning: format string is not a string literal |
| (potentially insecure) [-Wformat-security] |
| |
| Fixes: a3fb1e330dd2 ("pcrypt: Added sysfs interface to pcrypt") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| crypto/pcrypt.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c |
| index f8ec3d4ba4a80..a5718c0a3dc4e 100644 |
| --- a/crypto/pcrypt.c |
| +++ b/crypto/pcrypt.c |
| @@ -394,7 +394,7 @@ static int pcrypt_sysfs_add(struct padata_instance *pinst, const char *name) |
| int ret; |
| |
| pinst->kobj.kset = pcrypt_kset; |
| - ret = kobject_add(&pinst->kobj, NULL, name); |
| + ret = kobject_add(&pinst->kobj, NULL, "%s", name); |
| if (!ret) |
| kobject_uevent(&pinst->kobj, KOBJ_ADD); |
| |
| -- |
| 2.20.1 |
| |
