| From 26222c354c21cc93fa90cd355c2a3936f1c0fd05 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 19 Feb 2019 18:00:00 +0800 |
| Subject: regulator: pv88060: Fix array out-of-bounds access |
| |
| From: Axel Lin <axel.lin@ingics.com> |
| |
| [ Upstream commit 7cd415f875591bc66c5ecb49bf84ef97e80d7b0e ] |
| |
| Fix off-by-one while iterating current_limits array. |
| The valid index should be 0 ~ n_current_limits -1. |
| |
| Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver") |
| Signed-off-by: Axel Lin <axel.lin@ingics.com> |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/regulator/pv88060-regulator.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/regulator/pv88060-regulator.c b/drivers/regulator/pv88060-regulator.c |
| index 6c4afc73ecac3..d229245d2b5e8 100644 |
| --- a/drivers/regulator/pv88060-regulator.c |
| +++ b/drivers/regulator/pv88060-regulator.c |
| @@ -135,7 +135,7 @@ static int pv88060_set_current_limit(struct regulator_dev *rdev, int min, |
| int i; |
| |
| /* search for closest to maximum */ |
| - for (i = info->n_current_limits; i >= 0; i--) { |
| + for (i = info->n_current_limits - 1; i >= 0; i--) { |
| if (min <= info->current_limits[i] |
| && max >= info->current_limits[i]) { |
| return regmap_update_bits(rdev->regmap, |
| -- |
| 2.20.1 |
| |
