| From db43cef00cb6befaa24639fd2f7515e7cb5fbde7 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 19 Feb 2019 18:00:02 +0800 |
| Subject: regulator: pv88090: Fix array out-of-bounds access |
| |
| From: Axel Lin <axel.lin@ingics.com> |
| |
| [ Upstream commit a5455c9159414748bed4678184bf69989a4f7ba3 ] |
| |
| Fix off-by-one while iterating current_limits array. |
| The valid index should be 0 ~ n_current_limits -1. |
| |
| Fixes: c90456e36d9c ("regulator: pv88090: new regulator driver") |
| Signed-off-by: Axel Lin <axel.lin@ingics.com> |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/regulator/pv88090-regulator.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/regulator/pv88090-regulator.c b/drivers/regulator/pv88090-regulator.c |
| index 4216411753529..789652c9b0142 100644 |
| --- a/drivers/regulator/pv88090-regulator.c |
| +++ b/drivers/regulator/pv88090-regulator.c |
| @@ -157,7 +157,7 @@ static int pv88090_set_current_limit(struct regulator_dev *rdev, int min, |
| int i; |
| |
| /* search for closest to maximum */ |
| - for (i = info->n_current_limits; i >= 0; i--) { |
| + for (i = info->n_current_limits - 1; i >= 0; i--) { |
| if (min <= info->current_limits[i] |
| && max >= info->current_limits[i]) { |
| return regmap_update_bits(rdev->regmap, |
| -- |
| 2.20.1 |
| |
