| From 2ed6a9973605472e97c667fbd76a0222f18607f1 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 28 Mar 2019 17:18:41 +0300 |
| Subject: soc/fsl/qe: Fix an error code in qe_pin_request() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 5674a92ca4b7e5a6a19231edd10298d30324cd27 ] |
| |
| We forgot to set "err" on this error path. |
| |
| Fixes: 1a2d397a6eb5 ("gpio/powerpc: Eliminate duplication of of_get_named_gpio_flags()") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Li Yang <leoyang.li@nxp.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/soc/fsl/qe/gpio.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c |
| index 0aaf429f31d57..b5a7107a9c0a9 100644 |
| --- a/drivers/soc/fsl/qe/gpio.c |
| +++ b/drivers/soc/fsl/qe/gpio.c |
| @@ -152,8 +152,10 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index) |
| if (err < 0) |
| goto err0; |
| gc = gpio_to_chip(err); |
| - if (WARN_ON(!gc)) |
| + if (WARN_ON(!gc)) { |
| + err = -ENODEV; |
| goto err0; |
| + } |
| |
| if (!of_device_is_compatible(gc->of_node, "fsl,mpc8323-qe-pario-bank")) { |
| pr_debug("%s: tried to get a non-qe pin\n", __func__); |
| -- |
| 2.20.1 |
| |
