| From 0b4614fb383adf3f389ac5fa0992a6d8af145028 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 7 Jul 2019 15:17:19 +0300 |
| Subject: usb: host: xhci-hub: fix extra endianness conversion |
| |
| From: Ruslan Bilovol <ruslan.bilovol@gmail.com> |
| |
| [ Upstream commit 6269e4c76eacabaea0d0099200ae1a455768d208 ] |
| |
| Don't do extra cpu_to_le32 conversion for |
| put_unaligned_le32 because it is already implemented |
| in this function. |
| |
| Fixes sparse error: |
| xhci-hub.c:1152:44: warning: incorrect type in argument 1 (different base types) |
| xhci-hub.c:1152:44: expected unsigned int [usertype] val |
| xhci-hub.c:1152:44: got restricted __le32 [usertype] |
| |
| Fixes: 395f540 "xhci: support new USB 3.1 hub request to get extended port status" |
| Cc: Mathias Nyman <mathias.nyman@linux.intel.com> |
| Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com> |
| Link: https://lore.kernel.org/r/1562501839-26522-1-git-send-email-ruslan.bilovol@gmail.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/host/xhci-hub.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c |
| index 5cf5f3d9c1e59..04d36fa607342 100644 |
| --- a/drivers/usb/host/xhci-hub.c |
| +++ b/drivers/usb/host/xhci-hub.c |
| @@ -989,7 +989,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, |
| } |
| port_li = readl(port_array[wIndex] + PORTLI); |
| status = xhci_get_ext_port_status(temp, port_li); |
| - put_unaligned_le32(cpu_to_le32(status), &buf[4]); |
| + put_unaligned_le32(status, &buf[4]); |
| } |
| break; |
| case SetPortFeature: |
| -- |
| 2.20.1 |
| |
