| From 1970a3a9fdd0e93f4f714d1fe19d674b5446ac31 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 22 Mar 2022 14:18:30 +0800 |
| Subject: platform/x86: samsung-laptop: Fix an unsigned comparison which can |
| never be negative |
| |
| From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| |
| [ Upstream commit 0284d4d1be753f648f28b77bdfbe6a959212af5c ] |
| |
| Eliminate the follow smatch warnings: |
| |
| drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned |
| 'value' is never less than zero. |
| |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> |
| Link: https://lore.kernel.org/r/20220322061830.105579-1-jiapeng.chong@linux.alibaba.com |
| Reviewed-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/platform/x86/samsung-laptop.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c |
| index 8c146e2b6727..4664d3e191c8 100644 |
| --- a/drivers/platform/x86/samsung-laptop.c |
| +++ b/drivers/platform/x86/samsung-laptop.c |
| @@ -1125,8 +1125,6 @@ static void kbd_led_set(struct led_classdev *led_cdev, |
| |
| if (value > samsung->kbd_led.max_brightness) |
| value = samsung->kbd_led.max_brightness; |
| - else if (value < 0) |
| - value = 0; |
| |
| samsung->kbd_led_wk = value; |
| queue_work(samsung->led_workqueue, &samsung->kbd_led_work); |
| -- |
| 2.35.1 |
| |
