| From foo@baz Thu Dec 21 09:02:40 CET 2017 |
| From: Sreekanth Reddy <sreekanth.reddy@broadcom.com> |
| Date: Tue, 10 Oct 2017 18:41:18 +0530 |
| Subject: scsi: mpt3sas: Fix IO error occurs on pulling out a drive from RAID1 volume created on two SATA drive |
| |
| From: Sreekanth Reddy <sreekanth.reddy@broadcom.com> |
| |
| |
| [ Upstream commit 2ce9a3645299ba1752873d333d73f67620f4550b ] |
| |
| Whenever an I/O for a RAID volume fails with IOCStatus |
| MPI2_IOCSTATUS_SCSI_IOC_TERMINATED and SCSIStatus equal to |
| (MPI2_SCSI_STATE_TERMINATED | MPI2_SCSI_STATE_NO_SCSI_STATUS) then |
| return the I/O to SCSI midlayer with "DID_RESET" (i.e. retry the IO |
| infinite times) set in the host byte. |
| |
| Previously, the driver was completing the I/O with "DID_SOFT_ERROR" |
| which causes the I/O to be quickly retried. However, firmware needed |
| more time and hence I/Os were failing. |
| |
| Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@broadcom.com> |
| Reviewed-by: Tomas Henzl <thenzl@redhat.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <alexander.levin@verizon.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/scsi/mpt3sas/mpt3sas_scsih.c | 5 +++++ |
| 1 file changed, 5 insertions(+) |
| |
| --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c |
| +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c |
| @@ -4770,6 +4770,11 @@ _scsih_io_done(struct MPT3SAS_ADAPTER *i |
| } else if (log_info == VIRTUAL_IO_FAILED_RETRY) { |
| scmd->result = DID_RESET << 16; |
| break; |
| + } else if ((scmd->device->channel == RAID_CHANNEL) && |
| + (scsi_state == (MPI2_SCSI_STATE_TERMINATED | |
| + MPI2_SCSI_STATE_NO_SCSI_STATUS))) { |
| + scmd->result = DID_RESET << 16; |
| + break; |
| } |
| scmd->result = DID_SOFT_ERROR << 16; |
| break; |