| From d60667fc398ed34b3c7456b020481c55c760e503 Mon Sep 17 00:00:00 2001 |
| From: Daniel Jurgens <danielj@mellanox.com> |
| Date: Sat, 2 Feb 2019 11:09:42 +0200 |
| Subject: IB/core: Unregister notifier before freeing MAD security |
| |
| From: Daniel Jurgens <danielj@mellanox.com> |
| |
| commit d60667fc398ed34b3c7456b020481c55c760e503 upstream. |
| |
| If the notifier runs after the security context is freed an access of |
| freed memory can occur. |
| |
| Fixes: 47a2b338fe63 ("IB/core: Enforce security on management datagrams") |
| Signed-off-by: Daniel Jurgens <danielj@mellanox.com> |
| Reviewed-by: Parav Pandit <parav@mellanox.com> |
| Signed-off-by: Leon Romanovsky <leonro@mellanox.com> |
| Signed-off-by: Jason Gunthorpe <jgg@mellanox.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/infiniband/core/security.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/infiniband/core/security.c |
| +++ b/drivers/infiniband/core/security.c |
| @@ -727,9 +727,10 @@ void ib_mad_agent_security_cleanup(struc |
| if (!rdma_protocol_ib(agent->device, agent->port_num)) |
| return; |
| |
| - security_ib_free_security(agent->security); |
| if (agent->lsm_nb_reg) |
| unregister_lsm_notifier(&agent->lsm_nb); |
| + |
| + security_ib_free_security(agent->security); |
| } |
| |
| int ib_mad_enforce_security(struct ib_mad_agent_private *map, u16 pkey_index) |
