| From 40ca8757291ca7a8775498112d320205b2a2e571 Mon Sep 17 00:00:00 2001 |
| From: Bart Van Assche <bvanassche@acm.org> |
| Date: Fri, 25 Jan 2019 10:34:51 -0800 |
| Subject: scsi: RDMA/srpt: Fix a credit leak for aborted commands |
| |
| From: Bart Van Assche <bvanassche@acm.org> |
| |
| commit 40ca8757291ca7a8775498112d320205b2a2e571 upstream. |
| |
| Make sure that the next time a response is sent to the initiator that the |
| credit it had allocated for the aborted request gets freed. |
| |
| Cc: Doug Ledford <dledford@redhat.com> |
| Cc: Jason Gunthorpe <jgg@ziepe.ca> |
| Cc: Nicholas Bellinger <nab@linux-iscsi.org> |
| Cc: Mike Christie <mchristi@redhat.com> |
| Cc: Hannes Reinecke <hare@suse.com> |
| Cc: Christoph Hellwig <hch@lst.de> |
| Fixes: 131e6abc674e ("target: Add TFO->abort_task for aborted task resources release") # v3.15 |
| Signed-off-by: Bart Van Assche <bvanassche@acm.org> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/infiniband/ulp/srpt/ib_srpt.c | 11 +++++++++++ |
| 1 file changed, 11 insertions(+) |
| |
| --- a/drivers/infiniband/ulp/srpt/ib_srpt.c |
| +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c |
| @@ -2887,8 +2887,19 @@ static void srpt_queue_tm_rsp(struct se_ |
| srpt_queue_response(cmd); |
| } |
| |
| +/* |
| + * This function is called for aborted commands if no response is sent to the |
| + * initiator. Make sure that the credits freed by aborting a command are |
| + * returned to the initiator the next time a response is sent by incrementing |
| + * ch->req_lim_delta. |
| + */ |
| static void srpt_aborted_task(struct se_cmd *cmd) |
| { |
| + struct srpt_send_ioctx *ioctx = container_of(cmd, |
| + struct srpt_send_ioctx, cmd); |
| + struct srpt_rdma_ch *ch = ioctx->ch; |
| + |
| + atomic_inc(&ch->req_lim_delta); |
| } |
| |
| static int srpt_queue_status(struct se_cmd *cmd) |
