| From c00d21d417449c82d8691ba86c29c249289f308f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 9 Apr 2022 08:36:11 +0200 |
| Subject: sctp: Initialize daddr on peeled off socket |
| |
| From: Petr Malat <oss@malat.biz> |
| |
| [ Upstream commit 8467dda0c26583547731e7f3ea73fc3856bae3bf ] |
| |
| Function sctp_do_peeloff() wrongly initializes daddr of the original |
| socket instead of the peeled off socket, which makes getpeername() |
| return zeroes instead of the primary address. Initialize the new socket |
| instead. |
| |
| Fixes: d570ee490fb1 ("[SCTP]: Correctly set daddr for IPv6 sockets during peeloff") |
| Signed-off-by: Petr Malat <oss@malat.biz> |
| Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> |
| Link: https://lore.kernel.org/r/20220409063611.673193-1-oss@malat.biz |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/sctp/socket.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/net/sctp/socket.c b/net/sctp/socket.c |
| index 0a9e2c7d8e5f..e9b4ea3d934f 100644 |
| --- a/net/sctp/socket.c |
| +++ b/net/sctp/socket.c |
| @@ -5518,7 +5518,7 @@ int sctp_do_peeloff(struct sock *sk, sctp_assoc_t id, struct socket **sockp) |
| * Set the daddr and initialize id to something more random and also |
| * copy over any ip options. |
| */ |
| - sp->pf->to_sk_daddr(&asoc->peer.primary_addr, sk); |
| + sp->pf->to_sk_daddr(&asoc->peer.primary_addr, sock->sk); |
| sp->pf->copy_ip_options(sk, sock->sk); |
| |
| /* Populate the fields of the newsk from the oldsk and migrate the |
| -- |
| 2.35.1 |
| |
