| From a55a9a4c5c6253f6e4dea268af728664ac997790 Mon Sep 17 00:00:00 2001 |
| From: kernel test robot <lkp@intel.com> |
| Date: Thu, 21 Jan 2021 19:12:54 +0100 |
| Subject: usb: gadget: aspeed: add missing of_node_put |
| |
| From: kernel test robot <lkp@intel.com> |
| |
| commit a55a9a4c5c6253f6e4dea268af728664ac997790 upstream. |
| |
| Breaking out of for_each_child_of_node requires a put on the |
| child value. |
| |
| Generated by: scripts/coccinelle/iterators/for_each_child.cocci |
| |
| Fixes: 82c2d81361ec ("coccinelle: iterators: Add for_each_child.cocci script") |
| CC: Sumera Priyadarsini <sylphrenadin@gmail.com> |
| Reported-by: kernel test robot <lkp@intel.com> |
| Signed-off-by: kernel test robot <lkp@intel.com> |
| Signed-off-by: Julia Lawall <julia.lawall@inria.fr> |
| Cc: stable <stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2101211907060.14700@hadrien |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/usb/gadget/udc/aspeed-vhub/hub.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c |
| +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c |
| @@ -999,8 +999,10 @@ static int ast_vhub_of_parse_str_desc(st |
| str_array[offset].s = NULL; |
| |
| ret = ast_vhub_str_alloc_add(vhub, &lang_str); |
| - if (ret) |
| + if (ret) { |
| + of_node_put(child); |
| break; |
| + } |
| } |
| |
| return ret; |
