| From af505cad9567f7a500d34bf183696d570d7f6810 Mon Sep 17 00:00:00 2001 |
| From: Nirmoy Das <nirmoy.das@amd.com> |
| Date: Thu, 2 Sep 2021 12:29:17 +0200 |
| Subject: debugfs: debugfs_create_file_size(): use IS_ERR to check for error |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Nirmoy Das <nirmoy.das@amd.com> |
| |
| commit af505cad9567f7a500d34bf183696d570d7f6810 upstream. |
| |
| debugfs_create_file() returns encoded error so use IS_ERR for checking |
| return value. |
| |
| Reviewed-by: Christian Kรถnig <christian.koenig@amd.com> |
| Signed-off-by: Nirmoy Das <nirmoy.das@amd.com> |
| Fixes: ff9fb72bc077 ("debugfs: return error values, not NULL") |
| Cc: stable <stable@vger.kernel.org> |
| References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686 |
| Link: https://lore.kernel.org/r/20210902102917.2233-1-nirmoy.das@amd.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/debugfs/inode.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/debugfs/inode.c |
| +++ b/fs/debugfs/inode.c |
| @@ -524,7 +524,7 @@ void debugfs_create_file_size(const char |
| { |
| struct dentry *de = debugfs_create_file(name, mode, parent, data, fops); |
| |
| - if (de) |
| + if (!IS_ERR(de)) |
| d_inode(de)->i_size = file_size; |
| } |
| EXPORT_SYMBOL_GPL(debugfs_create_file_size); |