| From e8c2da7e329ce004fee748b921e4c765dc2fa338 Mon Sep 17 00:00:00 2001 |
| From: Jonathan Hsu <jonathan.hsu@mediatek.com> |
| Date: Fri, 24 Sep 2021 16:58:48 +0800 |
| Subject: scsi: ufs: Fix illegal offset in UPIU event trace |
| |
| From: Jonathan Hsu <jonathan.hsu@mediatek.com> |
| |
| commit e8c2da7e329ce004fee748b921e4c765dc2fa338 upstream. |
| |
| Fix incorrect index for UTMRD reference in ufshcd_add_tm_upiu_trace(). |
| |
| Link: https://lore.kernel.org/r/20210924085848.25500-1-jonathan.hsu@mediatek.com |
| Fixes: 4b42d557a8ad ("scsi: ufs: core: Fix wrong Task Tag used in task management request UPIUs") |
| Cc: stable@vger.kernel.org |
| Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> |
| Reviewed-by: Bart Van Assche <bvanassche@acm.org> |
| Signed-off-by: Jonathan Hsu <jonathan.hsu@mediatek.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/scsi/ufs/ufshcd.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/drivers/scsi/ufs/ufshcd.c |
| +++ b/drivers/scsi/ufs/ufshcd.c |
| @@ -318,8 +318,7 @@ static void ufshcd_add_query_upiu_trace( |
| static void ufshcd_add_tm_upiu_trace(struct ufs_hba *hba, unsigned int tag, |
| const char *str) |
| { |
| - int off = (int)tag - hba->nutrs; |
| - struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[off]; |
| + struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[tag]; |
| |
| trace_ufshcd_upiu(dev_name(hba->dev), str, &descp->req_header, |
| &descp->input_param1); |
