| From 3287b19c80edd52ba2b888b99f74749c593ff291 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 10 Mar 2021 17:01:46 +0200 |
| Subject: net/mlx5e: Allow to match on MPLS parameters only for MPLS over UDP |
| |
| From: Alaa Hleihel <alaa@nvidia.com> |
| |
| [ Upstream commit 7d6c86e3ccb5ceea767df5c7a9a17cdfccd3df9a ] |
| |
| Currently, we support hardware offload only for MPLS over UDP. |
| However, rules matching on MPLS parameters are now wrongly offloaded |
| for regular MPLS, without actually taking the parameters into |
| consideration when doing the offload. |
| Fix it by rejecting such unsupported rules. |
| |
| Fixes: 72046a91d134 ("net/mlx5e: Allow to match on mpls parameters") |
| Signed-off-by: Alaa Hleihel <alaa@nvidia.com> |
| Reviewed-by: Roi Dayan <roid@nvidia.com> |
| Signed-off-by: Saeed Mahameed <saeedm@nvidia.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 10 ++++++++++ |
| 1 file changed, 10 insertions(+) |
| |
| diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c |
| index e9b7da05f14a..95cbefed1b32 100644 |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c |
| @@ -2595,6 +2595,16 @@ static int __parse_cls_flower(struct mlx5e_priv *priv, |
| *match_level = MLX5_MATCH_L4; |
| } |
| |
| + /* Currenlty supported only for MPLS over UDP */ |
| + if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_MPLS) && |
| + !netif_is_bareudp(filter_dev)) { |
| + NL_SET_ERR_MSG_MOD(extack, |
| + "Matching on MPLS is supported only for MPLS over UDP"); |
| + netdev_err(priv->netdev, |
| + "Matching on MPLS is supported only for MPLS over UDP\n"); |
| + return -EOPNOTSUPP; |
| + } |
| + |
| return 0; |
| } |
| |
| -- |
| 2.30.1 |
| |
