| From c242f64e609aeef105a6c2f90c16434e5e95b0d4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 19 Mar 2021 17:41:39 +0100 |
| Subject: media: i2c: rdamc21: Fix warning on u8 cast |
| |
| From: Jacopo Mondi <jacopo+renesas@jmondi.org> |
| |
| [ Upstream commit 5f58ac04f36e32507d8f60fd47266ae2a60a2fa8 ] |
| |
| Sparse reports a warning on a cast to u8 of a 16 bits constant. |
| |
| drivers/media/i2c/rdacm21.c:348:62: warning: cast truncates bits |
| from constant value (300a becomes a) |
| |
| Even if the behaviour is intended, silence the sparse warning replacing |
| the cast with a bitwise & operation. |
| |
| Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module") |
| Reported-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> |
| Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/i2c/rdacm21.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c |
| index dcc21515e5a4..179d107f494c 100644 |
| --- a/drivers/media/i2c/rdacm21.c |
| +++ b/drivers/media/i2c/rdacm21.c |
| @@ -345,7 +345,7 @@ static int ov10640_initialize(struct rdacm21_device *dev) |
| /* Read OV10640 ID to test communications. */ |
| ov490_write_reg(dev, OV490_SCCB_SLAVE0_DIR, OV490_SCCB_SLAVE_READ); |
| ov490_write_reg(dev, OV490_SCCB_SLAVE0_ADDR_HIGH, OV10640_CHIP_ID >> 8); |
| - ov490_write_reg(dev, OV490_SCCB_SLAVE0_ADDR_LOW, (u8)OV10640_CHIP_ID); |
| + ov490_write_reg(dev, OV490_SCCB_SLAVE0_ADDR_LOW, OV10640_CHIP_ID & 0xff); |
| |
| /* Trigger SCCB slave transaction and give it some time to complete. */ |
| ov490_write_reg(dev, OV490_HOST_CMD, OV490_HOST_CMD_TRIGGER); |
| -- |
| 2.30.2 |
| |
