| From dca09ced7721e3796deb77ff12179b6964522d3a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 10 Apr 2021 23:16:41 +0300 |
| Subject: i2c: emev2: add IRQ check |
| |
| From: Sergey Shtylyov <s.shtylyov@omprussia.ru> |
| |
| [ Upstream commit bb6129c32867baa7988f7fd2066cf18ed662d240 ] |
| |
| The driver neglects to check the result of platform_get_irq()'s call and |
| blithely passes the negative error codes to devm_request_irq() (which |
| takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding |
| an original error code. Stop calling devm_request_irq() with invalid |
| IRQ #s. |
| |
| Fixes: 5faf6e1f58b4 ("i2c: emev2: add driver") |
| Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru> |
| Signed-off-by: Wolfram Sang <wsa@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/i2c/busses/i2c-emev2.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c |
| index 959d4912ec0d..0230a13a6ab7 100644 |
| --- a/drivers/i2c/busses/i2c-emev2.c |
| +++ b/drivers/i2c/busses/i2c-emev2.c |
| @@ -397,7 +397,10 @@ static int em_i2c_probe(struct platform_device *pdev) |
| |
| em_i2c_reset(&priv->adap); |
| |
| - priv->irq = platform_get_irq(pdev, 0); |
| + ret = platform_get_irq(pdev, 0); |
| + if (ret < 0) |
| + goto err_clk; |
| + priv->irq = ret; |
| ret = devm_request_irq(&pdev->dev, priv->irq, em_i2c_irq_handler, 0, |
| "em_i2c", priv); |
| if (ret) |
| -- |
| 2.30.2 |
| |
