| From 75d800b9d63739ce9a52fa80199ca313ac375ae2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 18 Oct 2021 02:16:22 +0000 |
| Subject: cavium: Return negative value when pci_alloc_irq_vectors() fails |
| |
| From: Zheyu Ma <zheyuma97@gmail.com> |
| |
| [ Upstream commit b2cddb44bddc1a9c5949a978bb454bba863264db ] |
| |
| During the process of driver probing, the probe function should return < 0 |
| for failure, otherwise, the kernel will treat value > 0 as success. |
| |
| Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c |
| index 9361f964bb9b2..816453a4f8d6c 100644 |
| --- a/drivers/net/ethernet/cavium/thunder/nic_main.c |
| +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c |
| @@ -1193,7 +1193,7 @@ static int nic_register_interrupts(struct nicpf *nic) |
| dev_err(&nic->pdev->dev, |
| "Request for #%d msix vectors failed, returned %d\n", |
| nic->num_vec, ret); |
| - return 1; |
| + return ret; |
| } |
| |
| /* Register mailbox interrupt handler */ |
| -- |
| 2.33.0 |
| |
