| From 34cfd7d3d0c544d60b419106cd143dac97413751 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 7 Oct 2021 02:37:06 -0400 |
| Subject: drm/plane-helper: fix uninitialized variable reference |
| |
| From: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> |
| |
| [ Upstream commit 7be28bd73f23e53d6e7f5fe891ba9503fc0c7210 ] |
| |
| drivers/gpu/drm/drm_plane_helper.c: In function 'drm_primary_helper_update': |
| drivers/gpu/drm/drm_plane_helper.c:113:32: error: 'visible' is used uninitialized [-Werror=uninitialized] |
| 113 | struct drm_plane_state plane_state = { |
| | ^~~~~~~~~~~ |
| drivers/gpu/drm/drm_plane_helper.c:178:14: note: 'visible' was declared here |
| 178 | bool visible; |
| | ^~~~~~~ |
| cc1: all warnings being treated as errors |
| |
| visible is an output, not an input. in practice this use might turn out |
| OK but it's still UB. |
| |
| Fixes: df86af9133b4 ("drm/plane-helper: Add drm_plane_helper_check_state()") |
| Reviewed-by: Simon Ser <contact@emersion.fr> |
| Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca> |
| Signed-off-by: Simon Ser <contact@emersion.fr> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20211007063706.305984-1-alex_y_xu@yahoo.ca |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/drm_plane_helper.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c |
| index 3aae7ea522f23..c3f2292dc93d5 100644 |
| --- a/drivers/gpu/drm/drm_plane_helper.c |
| +++ b/drivers/gpu/drm/drm_plane_helper.c |
| @@ -123,7 +123,6 @@ static int drm_plane_helper_check_update(struct drm_plane *plane, |
| .crtc_w = drm_rect_width(dst), |
| .crtc_h = drm_rect_height(dst), |
| .rotation = rotation, |
| - .visible = *visible, |
| }; |
| struct drm_crtc_state crtc_state = { |
| .crtc = crtc, |
| -- |
| 2.33.0 |
| |