| From b5a66d6d481ae7b82fb1c072afabde0d493ec0fc Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 5 Aug 2021 09:55:35 +0200 |
| Subject: media: s5p-mfc: fix possible null-pointer dereference in |
| s5p_mfc_probe() |
| |
| From: Tuo Li <islituo@gmail.com> |
| |
| [ Upstream commit 8515965e5e33f4feb56134348c95953f3eadfb26 ] |
| |
| The variable pdev is assigned to dev->plat_dev, and dev->plat_dev is |
| checked in: |
| if (!dev->plat_dev) |
| |
| This indicates both dev->plat_dev and pdev can be NULL. If so, the |
| function dev_err() is called to print error information. |
| dev_err(&pdev->dev, "No platform data specified\n"); |
| |
| However, &pdev->dev is an illegal address, and it is dereferenced in |
| dev_err(). |
| |
| To fix this possible null-pointer dereference, replace dev_err() with |
| mfc_err(). |
| |
| Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> |
| Signed-off-by: Tuo Li <islituo@gmail.com> |
| Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c |
| index b776f83e395e0..f8a5ed6bb9d7a 100644 |
| --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c |
| +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c |
| @@ -1279,7 +1279,7 @@ static int s5p_mfc_probe(struct platform_device *pdev) |
| spin_lock_init(&dev->condlock); |
| dev->plat_dev = pdev; |
| if (!dev->plat_dev) { |
| - dev_err(&pdev->dev, "No platform data specified\n"); |
| + mfc_err("No platform data specified\n"); |
| return -ENODEV; |
| } |
| |
| -- |
| 2.33.0 |
| |
