| From 02ee0e85b397b0d1d6bcad964ae64601f96d6b0a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 11 Oct 2021 15:39:12 +0300 |
| Subject: memstick: jmb38x_ms: use appropriate free function in |
| jmb38x_ms_alloc_host() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit beae4a6258e64af609ad5995cc6b6056eb0d898e ] |
| |
| The "msh" pointer is device managed, meaning that memstick_alloc_host() |
| calls device_initialize() on it. That means that it can't be free |
| using kfree() but must instead be freed with memstick_free_host(). |
| Otherwise it leads to a tiny memory leak of device resources. |
| |
| Fixes: 60fdd931d577 ("memstick: add support for JMicron jmb38x MemoryStick host controller") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Link: https://lore.kernel.org/r/20211011123912.GD15188@kili |
| Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/memstick/host/jmb38x_ms.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c |
| index 64fff6abe60e8..74d6686b35f77 100644 |
| --- a/drivers/memstick/host/jmb38x_ms.c |
| +++ b/drivers/memstick/host/jmb38x_ms.c |
| @@ -899,7 +899,7 @@ static struct memstick_host *jmb38x_ms_alloc_host(struct jmb38x_ms *jm, int cnt) |
| |
| iounmap(host->addr); |
| err_out_free: |
| - kfree(msh); |
| + memstick_free_host(msh); |
| return NULL; |
| } |
| |
| -- |
| 2.33.0 |
| |
