| From e4313be1599d397625c14fb7826996813622decf Mon Sep 17 00:00:00 2001 |
| From: =?UTF-8?q?Marek=20Beh=C3=BAn?= <kabel@kernel.org> |
| Date: Thu, 28 Oct 2021 20:56:54 +0200 |
| Subject: PCI: aardvark: Fix return value of MSI domain .alloc() method |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Marek Behún <kabel@kernel.org> |
| |
| commit e4313be1599d397625c14fb7826996813622decf upstream. |
| |
| MSI domain callback .alloc() (implemented by advk_msi_irq_domain_alloc() |
| function) should return zero on success, since non-zero value indicates |
| failure. |
| |
| When the driver was converted to generic MSI API in commit f21a8b1b6837 |
| ("PCI: aardvark: Move to MSI handling using generic MSI support"), it |
| was converted so that it returns hwirq number. |
| |
| Fix this. |
| |
| Link: https://lore.kernel.org/r/20211028185659.20329-3-kabel@kernel.org |
| Fixes: f21a8b1b6837 ("PCI: aardvark: Move to MSI handling using generic MSI support") |
| Signed-off-by: Pali Rohár <pali@kernel.org> |
| Signed-off-by: Marek Behún <kabel@kernel.org> |
| Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/pci/controller/pci-aardvark.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/pci/controller/pci-aardvark.c |
| +++ b/drivers/pci/controller/pci-aardvark.c |
| @@ -942,7 +942,7 @@ static int advk_msi_irq_domain_alloc(str |
| domain->host_data, handle_simple_irq, |
| NULL, NULL); |
| |
| - return hwirq; |
| + return 0; |
| } |
| |
| static void advk_msi_irq_domain_free(struct irq_domain *domain, |
