| From e660dbb68c6b3f7b9eb8b9775846a44f9798b719 Mon Sep 17 00:00:00 2001 |
| From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> |
| Date: Tue, 14 Sep 2021 14:18:06 +0200 |
| Subject: power: supply: max17042_battery: Prevent int underflow in set_soc_threshold |
| |
| From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> |
| |
| commit e660dbb68c6b3f7b9eb8b9775846a44f9798b719 upstream. |
| |
| max17042_set_soc_threshold gets called with offset set to 1, which means |
| that minimum threshold value would underflow once SOC got down to 0, |
| causing invalid alerts from the gauge. |
| |
| Fixes: e5f3872d2044 ("max17042: Add support for signalling change in SOC") |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm> |
| Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> |
| Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/power/supply/max17042_battery.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/power/supply/max17042_battery.c |
| +++ b/drivers/power/supply/max17042_battery.c |
| @@ -834,7 +834,8 @@ static void max17042_set_soc_threshold(s |
| regmap_read(map, MAX17042_RepSOC, &soc); |
| soc >>= 8; |
| soc_tr = (soc + off) << 8; |
| - soc_tr |= (soc - off); |
| + if (off < soc) |
| + soc_tr |= soc - off; |
| regmap_write(map, MAX17042_SALRT_Th, soc_tr); |
| } |
| |