| From 2c331e307e85adc0e249aa1355af08266127e21f Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 28 Oct 2021 15:28:22 +0800 |
| Subject: powerpc/44x/fsp2: add missing of_node_put |
| |
| From: Bixuan Cui <cuibixuan@linux.alibaba.com> |
| |
| [ Upstream commit 290fe8aa69ef5c51c778c0bb33f8ef0181c769f5 ] |
| |
| Early exits from for_each_compatible_node() should decrement the |
| node reference counter. Reported by Coccinelle: |
| |
| ./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function |
| "for_each_compatible_node" should have of_node_put() before return |
| around line 218. |
| |
| Fixes: 7813043e1bbc ("powerpc/44x/fsp2: Add irq error handlers") |
| Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com> |
| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> |
| Link: https://lore.kernel.org/r/1635406102-88719-1-git-send-email-cuibixuan@linux.alibaba.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/powerpc/platforms/44x/fsp2.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| diff --git a/arch/powerpc/platforms/44x/fsp2.c b/arch/powerpc/platforms/44x/fsp2.c |
| index b299e43f5ef94..823397c802def 100644 |
| --- a/arch/powerpc/platforms/44x/fsp2.c |
| +++ b/arch/powerpc/platforms/44x/fsp2.c |
| @@ -208,6 +208,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler) |
| if (irq == NO_IRQ) { |
| pr_err("device tree node %pOFn is missing a interrupt", |
| np); |
| + of_node_put(np); |
| return; |
| } |
| |
| @@ -215,6 +216,7 @@ static void node_irq_request(const char *compat, irq_handler_t errirq_handler) |
| if (rc) { |
| pr_err("fsp_of_probe: request_irq failed: np=%pOF rc=%d", |
| np, rc); |
| + of_node_put(np); |
| return; |
| } |
| } |
| -- |
| 2.33.0 |
| |