| From a22cdc6c79175659bd6d9945656c080d6a4728b6 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 6 Oct 2021 10:32:43 +0300 |
| Subject: scsi: csiostor: Uninitialized data in csio_ln_vnp_read_cbfn() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit f4875d509a0a78ad294a1a538d534b5ba94e685a ] |
| |
| This variable is just a temporary variable, used to do an endian |
| conversion. The problem is that the last byte is not initialized. After |
| the conversion is completely done, the last byte is discarded so it doesn't |
| cause a problem. But static checkers and the KMSan runtime checker can |
| detect the uninitialized read and will complain about it. |
| |
| Link: https://lore.kernel.org/r/20211006073242.GA8404@kili |
| Fixes: 5036f0a0ecd3 ("[SCSI] csiostor: Fix sparse warnings.") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/csiostor/csio_lnode.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/scsi/csiostor/csio_lnode.c b/drivers/scsi/csiostor/csio_lnode.c |
| index 23cbe4cda760e..c3bf590f5d685 100644 |
| --- a/drivers/scsi/csiostor/csio_lnode.c |
| +++ b/drivers/scsi/csiostor/csio_lnode.c |
| @@ -619,7 +619,7 @@ csio_ln_vnp_read_cbfn(struct csio_hw *hw, struct csio_mb *mbp) |
| struct fc_els_csp *csp; |
| struct fc_els_cssp *clsp; |
| enum fw_retval retval; |
| - __be32 nport_id; |
| + __be32 nport_id = 0; |
| |
| retval = FW_CMD_RETVAL_G(ntohl(rsp->alloc_to_len16)); |
| if (retval != FW_SUCCESS) { |
| -- |
| 2.33.0 |
| |