| From b0a3da7db71e315843796ba52c13229d32331e33 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 18 Oct 2021 01:56:21 +0000 |
| Subject: scsi: qla2xxx: Return -ENOMEM if kzalloc() fails |
| |
| From: Zheyu Ma <zheyuma97@gmail.com> |
| |
| [ Upstream commit 06634d5b6e923ed0d4772aba8def5a618f44c7fe ] |
| |
| The driver probing function should return < 0 for failure, otherwise |
| kernel will treat value > 0 as success. |
| |
| Link: https://lore.kernel.org/r/1634522181-31166-1-git-send-email-zheyuma97@gmail.com |
| Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> |
| Signed-off-by: Zheyu Ma <zheyuma97@gmail.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/qla2xxx/qla_os.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c |
| index 8b68879058132..049a68c59c137 100644 |
| --- a/drivers/scsi/qla2xxx/qla_os.c |
| +++ b/drivers/scsi/qla2xxx/qla_os.c |
| @@ -4066,7 +4066,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len, |
| ql_dbg_pci(ql_dbg_init, ha->pdev, |
| 0xe0ee, "%s: failed alloc dsd\n", |
| __func__); |
| - return 1; |
| + return -ENOMEM; |
| } |
| ha->dif_bundle_kallocs++; |
| |
| -- |
| 2.33.0 |
| |
