| From e5b3d30f3758c6a29ae1ed23e57ce9e8bf126a70 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 5 Oct 2021 16:45:16 +0300 |
| Subject: serial: 8250_dw: Drop wrong use of ACPI_PTR() |
| |
| From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| |
| [ Upstream commit ebabb77a2a115b6c5e68f7364b598310b5f61fb2 ] |
| |
| ACPI_PTR() is more harmful than helpful. For example, in this case |
| if CONFIG_ACPI=n, the ID table left unused which is not what we want. |
| |
| Instead of adding ifdeffery here and there, drop ACPI_PTR(). |
| |
| Fixes: 6a7320c4669f ("serial: 8250_dw: Add ACPI 5.0 support") |
| Reported-by: Daniel Palmer <daniel@0x0f.com> |
| Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Link: https://lore.kernel.org/r/20211005134516.23218-1-andriy.shevchenko@linux.intel.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/tty/serial/8250/8250_dw.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c |
| index 51a7d3b19b394..381c5117aec1b 100644 |
| --- a/drivers/tty/serial/8250/8250_dw.c |
| +++ b/drivers/tty/serial/8250/8250_dw.c |
| @@ -660,7 +660,7 @@ static struct platform_driver dw8250_platform_driver = { |
| .name = "dw-apb-uart", |
| .pm = &dw8250_pm_ops, |
| .of_match_table = dw8250_of_match, |
| - .acpi_match_table = ACPI_PTR(dw8250_acpi_match), |
| + .acpi_match_table = dw8250_acpi_match, |
| }, |
| .probe = dw8250_probe, |
| .remove = dw8250_remove, |
| -- |
| 2.33.0 |
| |
