| From e554dc8b6fcbc61025c126a6889650a75696ece0 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 22 Oct 2021 16:21:04 +0200 |
| Subject: spi: spl022: fix Microwire full duplex mode |
| |
| From: Thomas Perrot <thomas.perrot@bootlin.com> |
| |
| [ Upstream commit d81d0e41ed5fe7229a2c9a29d13bad288c7cf2d2 ] |
| |
| There are missing braces in the function that verify controller parameters, |
| then an error is always returned when the parameter to select Microwire |
| frames operation is used on devices allowing it. |
| |
| Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com> |
| Link: https://lore.kernel.org/r/20211022142104.1386379-1-thomas.perrot@bootlin.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/spi/spi-pl022.c | 5 +++-- |
| 1 file changed, 3 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c |
| index 7fedea67159c5..8523bb4f6a62e 100644 |
| --- a/drivers/spi/spi-pl022.c |
| +++ b/drivers/spi/spi-pl022.c |
| @@ -1720,12 +1720,13 @@ static int verify_controller_parameters(struct pl022 *pl022, |
| return -EINVAL; |
| } |
| } else { |
| - if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) |
| + if (chip_info->duplex != SSP_MICROWIRE_CHANNEL_FULL_DUPLEX) { |
| dev_err(&pl022->adev->dev, |
| "Microwire half duplex mode requested," |
| " but this is only available in the" |
| " ST version of PL022\n"); |
| - return -EINVAL; |
| + return -EINVAL; |
| + } |
| } |
| } |
| return 0; |
| -- |
| 2.33.0 |
| |