| From 33a5471f8da976bf271a1ebbd6b9d163cb0cb6aa Mon Sep 17 00:00:00 2001 |
| From: Marek Vasut <marex@denx.de> |
| Date: Tue, 21 Sep 2021 19:35:06 +0200 |
| Subject: video: backlight: Drop maximum brightness override for brightness zero |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Marek Vasut <marex@denx.de> |
| |
| commit 33a5471f8da976bf271a1ebbd6b9d163cb0cb6aa upstream. |
| |
| The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper |
| in backlight.c") says that gpio-backlight uses brightness as power state. |
| This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight: |
| Correct initial power state handling") and other backlight drivers do not |
| require this workaround. Drop the workaround. |
| |
| This fixes the case where e.g. pwm-backlight can perfectly well be set to |
| brightness 0 on boot in DT, which without this patch leads to the display |
| brightness to be max instead of off. |
| |
| Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c") |
| Cc: <stable@vger.kernel.org> # 5.4+ |
| Cc: <stable@vger.kernel.org> # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling |
| Signed-off-by: Marek Vasut <marex@denx.de> |
| Acked-by: Noralf TrΓΈnnes <noralf@tronnes.org> |
| Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> |
| Signed-off-by: Lee Jones <lee.jones@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/video/backlight/backlight.c | 6 ------ |
| 1 file changed, 6 deletions(-) |
| |
| --- a/drivers/video/backlight/backlight.c |
| +++ b/drivers/video/backlight/backlight.c |
| @@ -630,12 +630,6 @@ struct backlight_device *of_find_backlig |
| of_node_put(np); |
| if (!bd) |
| return ERR_PTR(-EPROBE_DEFER); |
| - /* |
| - * Note: gpio_backlight uses brightness as |
| - * power state during probe |
| - */ |
| - if (!bd->props.brightness) |
| - bd->props.brightness = bd->props.max_brightness; |
| } |
| } |
| |