| From 54858c6f61b25354105049fdde2a86c199c1d178 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 8 Oct 2021 15:44:17 +0800 |
| Subject: xen-pciback: Fix return in pm_ctrl_init() |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| [ Upstream commit 4745ea2628bb43a7ec34b71763b5a56407b33990 ] |
| |
| Return NULL instead of passing to ERR_PTR while err is zero, |
| this fix smatch warnings: |
| drivers/xen/xen-pciback/conf_space_capability.c:163 |
| pm_ctrl_init() warn: passing zero to 'ERR_PTR' |
| |
| Fixes: a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup some code.") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Reviewed-by: Juergen Gross <jgross@suse.com> |
| Link: https://lore.kernel.org/r/20211008074417.8260-1-yuehaibing@huawei.com |
| Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/xen/xen-pciback/conf_space_capability.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/xen/xen-pciback/conf_space_capability.c b/drivers/xen/xen-pciback/conf_space_capability.c |
| index e5694133ebe57..42f0f64fcba47 100644 |
| --- a/drivers/xen/xen-pciback/conf_space_capability.c |
| +++ b/drivers/xen/xen-pciback/conf_space_capability.c |
| @@ -160,7 +160,7 @@ static void *pm_ctrl_init(struct pci_dev *dev, int offset) |
| } |
| |
| out: |
| - return ERR_PTR(err); |
| + return err ? ERR_PTR(err) : NULL; |
| } |
| |
| static const struct config_field caplist_pm[] = { |
| -- |
| 2.33.0 |
| |
