| From f33113b542219448fa02d77ca1c6f4265bd7f130 Mon Sep 17 00:00:00 2001 |
| From: YueHaibing <yuehaibing@huawei.com> |
| Date: Mon, 30 Dec 2019 11:29:45 +0800 |
| Subject: mtd: sharpslpart: Fix unsigned comparison to zero |
| |
| From: YueHaibing <yuehaibing@huawei.com> |
| |
| commit f33113b542219448fa02d77ca1c6f4265bd7f130 upstream. |
| |
| The unsigned variable log_num is being assigned a return value |
| from the call to sharpsl_nand_get_logical_num that can return |
| -EINVAL. |
| |
| Detected using Coccinelle: |
| ./drivers/mtd/parsers/sharpslpart.c:207:6-13: WARNING: Unsigned expression compared with zero: log_num > 0 |
| |
| Fixes: 8a4580e4d298 ("mtd: sharpslpart: Add sharpslpart partition parser") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/mtd/parsers/sharpslpart.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/mtd/parsers/sharpslpart.c |
| +++ b/drivers/mtd/parsers/sharpslpart.c |
| @@ -165,10 +165,10 @@ static int sharpsl_nand_get_logical_num( |
| |
| static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl) |
| { |
| - unsigned int block_num, log_num, phymax; |
| + unsigned int block_num, phymax; |
| + int i, ret, log_num; |
| loff_t block_adr; |
| u8 *oob; |
| - int i, ret; |
| |
| oob = kzalloc(mtd->oobsize, GFP_KERNEL); |
| if (!oob) |
