| From e0b4f4e0cf7fa9d62628d4249c765ec18dffd143 Mon Sep 17 00:00:00 2001 |
| From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> |
| Date: Fri, 13 Dec 2019 12:19:34 +0530 |
| Subject: watchdog: qcom: Use platform_get_irq_optional() for bark irq |
| |
| From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> |
| |
| commit e0b4f4e0cf7fa9d62628d4249c765ec18dffd143 upstream. |
| |
| platform_get_irq() prints an error message when the interrupt |
| is not available. So on platforms where bark interrupt is |
| not specified, following error message is observed on SDM845. |
| |
| [ 2.975888] qcom_wdt 17980000.watchdog: IRQ index 0 not found |
| |
| This is also seen on SC7180, SM8150 SoCs as well. |
| Fix this by using platform_get_irq_optional() instead. |
| |
| Fixes: 36375491a4395654 ("watchdog: qcom: support pre-timeout when the bark irq is available") |
| Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> |
| Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> |
| Reviewed-by: Guenter Roeck <linux@roeck-us.net> |
| Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
| Link: https://lore.kernel.org/r/20191213064934.4112-1-saiprakash.ranjan@codeaurora.org |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/watchdog/qcom-wdt.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/watchdog/qcom-wdt.c |
| +++ b/drivers/watchdog/qcom-wdt.c |
| @@ -246,7 +246,7 @@ static int qcom_wdt_probe(struct platfor |
| } |
| |
| /* check if there is pretimeout support */ |
| - irq = platform_get_irq(pdev, 0); |
| + irq = platform_get_irq_optional(pdev, 0); |
| if (irq > 0) { |
| ret = devm_request_irq(dev, irq, qcom_wdt_isr, |
| IRQF_TRIGGER_RISING, |