| From 4b17ea31971131026bab74d8f92d9ff9b3d8716e Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 5 Dec 2019 09:54:00 +0000 |
| Subject: crypto: atmel-{aes,tdes} - Do not save IV for ECB mode |
| |
| From: Tudor Ambarus <tudor.ambarus@microchip.com> |
| |
| [ Upstream commit c65d123742a7bf2a5bc9fa8398e1fd2376eb4c43 ] |
| |
| ECB mode does not use IV. |
| |
| Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/crypto/atmel-aes.c | 9 +++++++-- |
| drivers/crypto/atmel-tdes.c | 7 +++++-- |
| 2 files changed, 12 insertions(+), 4 deletions(-) |
| |
| diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c |
| index 24f1fba6513ef..7b7079db2e860 100644 |
| --- a/drivers/crypto/atmel-aes.c |
| +++ b/drivers/crypto/atmel-aes.c |
| @@ -515,6 +515,9 @@ static void atmel_aes_set_iv_as_last_ciphertext_block(struct atmel_aes_dev *dd) |
| |
| static inline int atmel_aes_complete(struct atmel_aes_dev *dd, int err) |
| { |
| + struct skcipher_request *req = skcipher_request_cast(dd->areq); |
| + struct atmel_aes_reqctx *rctx = skcipher_request_ctx(req); |
| + |
| #if IS_ENABLED(CONFIG_CRYPTO_DEV_ATMEL_AUTHENC) |
| if (dd->ctx->is_aead) |
| atmel_aes_authenc_complete(dd, err); |
| @@ -523,7 +526,8 @@ static inline int atmel_aes_complete(struct atmel_aes_dev *dd, int err) |
| clk_disable(dd->iclk); |
| dd->flags &= ~AES_FLAGS_BUSY; |
| |
| - if (!dd->ctx->is_aead) |
| + if (!dd->ctx->is_aead && |
| + (rctx->mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_ECB) |
| atmel_aes_set_iv_as_last_ciphertext_block(dd); |
| |
| if (dd->is_async) |
| @@ -1121,7 +1125,8 @@ static int atmel_aes_crypt(struct skcipher_request *req, unsigned long mode) |
| rctx = skcipher_request_ctx(req); |
| rctx->mode = mode; |
| |
| - if (!(mode & AES_FLAGS_ENCRYPT) && (req->src == req->dst)) { |
| + if ((mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_ECB && |
| + !(mode & AES_FLAGS_ENCRYPT) && req->src == req->dst) { |
| unsigned int ivsize = crypto_skcipher_ivsize(skcipher); |
| |
| if (req->cryptlen >= ivsize) |
| diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c |
| index 0c1f79b30fc1b..eaa14a80d40ce 100644 |
| --- a/drivers/crypto/atmel-tdes.c |
| +++ b/drivers/crypto/atmel-tdes.c |
| @@ -600,12 +600,14 @@ atmel_tdes_set_iv_as_last_ciphertext_block(struct atmel_tdes_dev *dd) |
| static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err) |
| { |
| struct skcipher_request *req = dd->req; |
| + struct atmel_tdes_reqctx *rctx = skcipher_request_ctx(req); |
| |
| clk_disable_unprepare(dd->iclk); |
| |
| dd->flags &= ~TDES_FLAGS_BUSY; |
| |
| - atmel_tdes_set_iv_as_last_ciphertext_block(dd); |
| + if ((rctx->mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB) |
| + atmel_tdes_set_iv_as_last_ciphertext_block(dd); |
| |
| req->base.complete(&req->base, err); |
| } |
| @@ -727,7 +729,8 @@ static int atmel_tdes_crypt(struct skcipher_request *req, unsigned long mode) |
| |
| rctx->mode = mode; |
| |
| - if (!(mode & TDES_FLAGS_ENCRYPT) && req->src == req->dst) { |
| + if ((mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB && |
| + !(mode & TDES_FLAGS_ENCRYPT) && req->src == req->dst) { |
| unsigned int ivsize = crypto_skcipher_ivsize(skcipher); |
| |
| if (req->cryptlen >= ivsize) |
| -- |
| 2.20.1 |
| |