| From foo@baz Sun 09 Feb 2020 10:47:54 PM CET |
| From: Dejin Zheng <zhengdejin5@gmail.com> |
| Date: Thu, 6 Feb 2020 23:29:17 +0800 |
| Subject: net: stmmac: fix a possible endless loop |
| |
| From: Dejin Zheng <zhengdejin5@gmail.com> |
| |
| [ Upstream commit 7d10f0774f9e32aa2f2e012f7fcb312a2ce422b9 ] |
| |
| It forgot to reduce the value of the variable retry in a while loop |
| in the ethqos_configure() function. It may cause an endless loop and |
| without timeout. |
| |
| Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") |
| Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com> |
| Acked-by: Vinod Koul <vkoul@kernel.org> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c |
| +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c |
| @@ -413,6 +413,7 @@ static int ethqos_configure(struct qcom_ |
| dll_lock = rgmii_readl(ethqos, SDC4_STATUS); |
| if (dll_lock & SDC4_STATUS_DLL_LOCK) |
| break; |
| + retry--; |
| } while (retry > 0); |
| if (!retry) |
| dev_err(ðqos->pdev->dev, |
