| From 2e269e8abd87b2e51bdff1ea5b57618855c84a2b Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 19 Nov 2025 10:09:57 +0100 |
| Subject: HID: hid-pl: handle probe errors |
| |
| From: Oliver Neukum <oneukum@suse.com> |
| |
| [ Upstream commit 3756a272d2cf356d2203da8474d173257f5f8521 ] |
| |
| Errors in init must be reported back or we'll |
| follow a NULL pointer the first time FF is used. |
| |
| Fixes: 20eb127906709 ("hid: force feedback driver for PantherLord USB/PS2 2in1 Adapter") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Oliver Neukum <oneukum@suse.com> |
| Signed-off-by: Jiri Kosina <jkosina@suse.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/hid/hid-pl.c | 7 ++++++- |
| 1 file changed, 6 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/hid/hid-pl.c b/drivers/hid/hid-pl.c |
| index 93fb07ec31802..d1a1ddd933abd 100644 |
| --- a/drivers/hid/hid-pl.c |
| +++ b/drivers/hid/hid-pl.c |
| @@ -194,9 +194,14 @@ static int pl_probe(struct hid_device *hdev, const struct hid_device_id *id) |
| goto err; |
| } |
| |
| - plff_init(hdev); |
| + ret = plff_init(hdev); |
| + if (ret) |
| + goto stop; |
| |
| return 0; |
| + |
| +stop: |
| + hid_hw_stop(hdev); |
| err: |
| return ret; |
| } |
| -- |
| 2.51.0 |
| |
