| From dbff82870ae043489d9af5dd06f37e1d0b923493 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 24 Dec 2025 10:38:19 +0800 |
| Subject: RDMA/rtrs: server: remove dead code |
| |
| From: Honggang LI <honggangli@163.com> |
| |
| [ Upstream commit a3572bdc3a028ca47f77d7166ac95b719cf77d50 ] |
| |
| As rkey had been initialized to zero, the WARN_ON_ONCE should never been |
| triggered. Remove it. |
| |
| Fixes: 9cb837480424 ("RDMA/rtrs: server: main functionality") |
| Signed-off-by: Honggang LI <honggangli@163.com> |
| Link: https://patch.msgid.link/20251224023819.138846-1-honggangli@163.com |
| Signed-off-by: Leon Romanovsky <leon@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/infiniband/ulp/rtrs/rtrs-srv.c | 8 +------- |
| 1 file changed, 1 insertion(+), 7 deletions(-) |
| |
| diff --git a/drivers/infiniband/ulp/rtrs/rtrs-srv.c b/drivers/infiniband/ulp/rtrs/rtrs-srv.c |
| index 3e6f12f98a890..bb19bbc564413 100644 |
| --- a/drivers/infiniband/ulp/rtrs/rtrs-srv.c |
| +++ b/drivers/infiniband/ulp/rtrs/rtrs-srv.c |
| @@ -239,7 +239,6 @@ static int rdma_write_sg(struct rtrs_srv_op *id) |
| size_t sg_cnt; |
| int err, offset; |
| bool need_inval; |
| - u32 rkey = 0; |
| struct ib_reg_wr rwr; |
| struct ib_sge *plist; |
| struct ib_sge list; |
| @@ -271,11 +270,6 @@ static int rdma_write_sg(struct rtrs_srv_op *id) |
| wr->wr.num_sge = 1; |
| wr->remote_addr = le64_to_cpu(id->rd_msg->desc[0].addr); |
| wr->rkey = le32_to_cpu(id->rd_msg->desc[0].key); |
| - if (rkey == 0) |
| - rkey = wr->rkey; |
| - else |
| - /* Only one key is actually used */ |
| - WARN_ON_ONCE(rkey != wr->rkey); |
| |
| wr->wr.opcode = IB_WR_RDMA_WRITE; |
| wr->wr.wr_cqe = &io_comp_cqe; |
| @@ -308,7 +302,7 @@ static int rdma_write_sg(struct rtrs_srv_op *id) |
| inv_wr.opcode = IB_WR_SEND_WITH_INV; |
| inv_wr.wr_cqe = &io_comp_cqe; |
| inv_wr.send_flags = 0; |
| - inv_wr.ex.invalidate_rkey = rkey; |
| + inv_wr.ex.invalidate_rkey = wr->rkey; |
| } |
| |
| imm_wr.wr.next = NULL; |
| -- |
| 2.51.0 |
| |